Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1057823005: Fix the units for the draw_properties benchmark. (Closed)

Created:
5 years, 8 months ago by Ian Vollick
Modified:
5 years, 8 months ago
Reviewers:
eakuefner, sullivan, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the units for the draw_properties benchmark. The dashboard is currently confused about which direction indicates an improvement. This CL makes that explicit. BUG=470272 Committed: https://crrev.com/e78bd6e3e47771060cd011ea42af8367320552bd Cr-Commit-Position: refs/heads/master@{#325317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/perf/measurements/draw_properties.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/unit-info.json View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Ian Vollick
5 years, 8 months ago (2015-04-15 20:05:18 UTC) #2
Ian Vollick
5 years, 8 months ago (2015-04-15 20:05:37 UTC) #3
eakuefner
+dtu OWNER lgtm
5 years, 8 months ago (2015-04-15 20:07:26 UTC) #5
sullivan
lgtm
5 years, 8 months ago (2015-04-15 20:27:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057823005/1
5 years, 8 months ago (2015-04-15 20:29:34 UTC) #9
dtu
lgtm
5 years, 8 months ago (2015-04-15 20:32:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 21:52:58 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 21:55:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e78bd6e3e47771060cd011ea42af8367320552bd
Cr-Commit-Position: refs/heads/master@{#325317}

Powered by Google App Engine
This is Rietveld 408576698