Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1057813002: Fixed the range information for string lengths. (Closed)

Created:
5 years, 8 months ago by Sven Panne
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fixed the range information for string lengths. Currently, this doesn't really help to generate better code, nevertheless this is the right thing to do. When our type system(s) are fixed, this should avoid falling back to floating point operations in various cases. Committed: https://crrev.com/15928708228db0e02218746c37086f58576be206 Cr-Commit-Position: refs/heads/master@{#27578}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M src/compiler/access-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 8 months ago (2015-04-02 07:52:09 UTC) #2
Michael Starzinger
LGTM.
5 years, 8 months ago (2015-04-02 08:21:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057813002/1
5 years, 8 months ago (2015-04-02 08:31:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-02 08:32:53 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 08:33:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15928708228db0e02218746c37086f58576be206
Cr-Commit-Position: refs/heads/master@{#27578}

Powered by Google App Engine
This is Rietveld 408576698