net/socket/ssl_client_socket_nss.cc - Issue 1057733002: Require ECDHE for False Start.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 1057733002: Require ECDHE for False Start. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix components build Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_client_socket_nss.cc

diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc

index 547ab7650c5d74a936805dcf28311c6a62d0603f..3414ba0de21e9e8681ca44c2c66568f5c73ebd41 100644

--- a/net/socket/ssl_client_socket_nss.cc

+++ b/net/socket/ssl_client_socket_nss.cc

@@ -1621,7 +1621,7 @@ SECStatus SSLClientSocketNSS::Core::CanFalseStartCallback(

SSL_GetChannelInfo(socket, &channel_info, sizeof(channel_info));

if (ok != SECSuccess || channel_info.length != sizeof(channel_info) ||

channel_info.protocolVersion < SSL_LIBRARY_VERSION_TLS_1_2 ||

- !IsSecureTLSCipherSuite(channel_info.cipherSuite)) {

+ !IsFalseStartableTLSCipherSuite(channel_info.cipherSuite)) {

*can_false_start = PR_FALSE;

return SECSuccess;

}

« no previous file with comments | « DEPS ('k') | net/socket/ssl_client_socket_unittest.cc » ('j') | no next file with comments »