test/mac/gyptest-lto.py - Issue 1057723002: Address scottmg comments from https://codereview.chromium.org/1003273007/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/mac/gyptest-lto.py

Issue 1057723002: Address scottmg comments from https://codereview.chromium.org/1003273007/. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/mac/gyptest-lto.py

diff --git a/test/mac/gyptest-lto.py b/test/mac/gyptest-lto.py

index 37182d981f40d313859e5692fe962f5fc1b4e15c..5171544750525991dbc56c0fc9ac7ab266db21da 100644

--- a/test/mac/gyptest-lto.py

+++ b/test/mac/gyptest-lto.py

@@ -17,8 +17,6 @@ import sys

if sys.platform == 'darwin':

test = TestGyp.TestGyp(formats=['ninja', 'make', 'xcode'])

- #if test.format == 'xcode-ninja':

- # test.skip_test()

CHDIR = 'lto'

test.run_gyp('test.gyp', chdir=CHDIR)

« no previous file with comments | « no previous file | test/mac/lto/test.gyp » ('j') | no next file with comments »