Issue 1057723002: Address scottmg comments from https://codereview.chromium.org/1003273007/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1057723002: Address scottmg comments from https://codereview.chromium.org/1003273007/. (Closed)

Created:
5 years, 8 months ago by Nico

Modified:
5 years, 8 months ago

Reviewers:
scottmg

CC:
gyp-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/gyp.git@master

Target Ref:
refs/heads/master

Project:
gyp

Visibility:
Public.

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -2 lines)			Patch
	M	test/mac/gyptest-lto.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	A	test/mac/lto/test.gyp	View		1 chunk	+35 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Nico

5 years, 8 months ago (2015-04-01 23:55:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2889664b9fa88cce175c5c7cdf207d28420a7412.