Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: sync/syncable/syncable_unittest.cc

Issue 1057663002: [Sync] Eliminate friends from Directory by exposing kernel via accessor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes from review. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/syncable/syncable_base_transaction.cc ('k') | sync/syncable/syncable_write_transaction.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/syncable/syncable_unittest.cc
diff --git a/sync/syncable/syncable_unittest.cc b/sync/syncable/syncable_unittest.cc
index d1c6ae86d187bc90afeb8003ed108f92c9d756a4..f7d85ccc19f9ea0ca8e86c60f79fd564439d81bd 100644
--- a/sync/syncable/syncable_unittest.cc
+++ b/sync/syncable/syncable_unittest.cc
@@ -561,17 +561,15 @@ TEST_F(SyncableDirectoryManagement, TestFileRelease) {
base::FilePath path =
temp_dir_.path().Append(Directory::kSyncDatabaseFilename);
- Directory dir(new OnDiskDirectoryBackingStore("ScopeTest", path),
- &handler_,
- NULL,
- NULL,
- NULL);
- DirOpenResult result =
- dir.Open("ScopeTest", &delegate_, NullTransactionObserver());
- ASSERT_EQ(result, OPENED);
- dir.Close();
-
- // Closing the directory should have released the backing database file.
+ {
+ Directory dir(new OnDiskDirectoryBackingStore("ScopeTest", path), &handler_,
+ NULL, NULL, NULL);
+ DirOpenResult result =
+ dir.Open("ScopeTest", &delegate_, NullTransactionObserver());
+ ASSERT_EQ(result, OPENED);
+ }
+
+ // Destroying the directory should have released the backing database file.
ASSERT_TRUE(base::DeleteFile(path, true));
}
« no previous file with comments | « sync/syncable/syncable_base_transaction.cc ('k') | sync/syncable/syncable_write_transaction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698