sync/internal_api/sync_rollback_manager_base.cc - Issue 1057663002: [Sync] Eliminate friends from Directory by exposing kernel via accessor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/sync_rollback_manager_base.cc

Issue 1057663002: [Sync] Eliminate friends from Directory by exposing kernel via accessor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes from review. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/internal_api/sync_rollback_manager_base.cc

diff --git a/sync/internal_api/sync_rollback_manager_base.cc b/sync/internal_api/sync_rollback_manager_base.cc

index 587ea56626fca787c837fda878cd560cf70b2908..80a63c5d2632fda3ae5958f506ee993ed4bbc9ae 100644

--- a/sync/internal_api/sync_rollback_manager_base.cc

+++ b/sync/internal_api/sync_rollback_manager_base.cc

@@ -137,7 +137,6 @@ void SyncRollbackManagerBase::SaveChanges() {

void SyncRollbackManagerBase::ShutdownOnSyncThread(ShutdownReason reason) {

if (initialized_) {

- share_.directory->Close();

share_.directory.reset();

initialized_ = false;

}

« no previous file with comments | « no previous file | sync/syncable/directory.h » ('j') | no next file with comments »