Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: ports/jsoncpp/build.sh

Issue 1057623004: Update upstream version of jsoncpp and run tests (Closed) Base URL: https://chromium.googlesource.com/external/naclports.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build_tools/XCompile-nacl.cmake ('k') | ports/jsoncpp/nacl.patch » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ports/jsoncpp/build.sh
diff --git a/ports/jsoncpp/build.sh b/ports/jsoncpp/build.sh
index 5385413e5a348d107662e508723258be9809b966..492e053cea081b1b6111cd80719014357d589b1b 100644
--- a/ports/jsoncpp/build.sh
+++ b/ports/jsoncpp/build.sh
@@ -2,26 +2,18 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-BUILD_DIR=${SRC_DIR}
+# The NaCL SDK includes a version of jsoncpp conflicts with this one.
+# Remove the SDK include path so that these headers don't get used
+# during the build.
+NACLPORTS_CPPFLAGS=${NACLPORTS_CPPFLAGS/-I${NACL_SDK_ROOT}\/include/}
-BuildStep() {
- export CXXCMD="${NACLCC} -Iinclude -I."
- LogExecute ${CXXCMD} -c src/lib_json/json_reader.cpp
- LogExecute ${CXXCMD} -c src/lib_json/json_value.cpp
- LogExecute ${CXXCMD} -c src/lib_json/json_writer.cpp
+EXECUTABLES=src/test_lib_json/jsoncpp_test
- LogExecute ${NACLAR} rcs libjsoncpp.a \
- json_reader.o \
- json_value.o \
- json_writer.o
+EXTRA_CMAKE_ARGS="-DJSONCPP_WITH_POST_BUILD_UNITTEST=OFF"
- LogExecute ${NACLRANLIB} libjsoncpp.a
-}
-
-
-InstallStep() {
- MakeDir ${DESTDIR_LIB}
- MakeDir ${DESTDIR_INCLUDE}
- LogExecute cp libjsoncpp.a ${DESTDIR_LIB}
- LogExecute cp -R include/json ${DESTDIR_INCLUDE}
+TestStep() {
+ if [ "${TOOLCHAIN}" = "pnacl" ]; then
+ return
+ fi
+ LogExecute src/test_lib_json/jsoncpp_test.sh
}
« no previous file with comments | « build_tools/XCompile-nacl.cmake ('k') | ports/jsoncpp/nacl.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698