Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1057623004: Update upstream version of jsoncpp and run tests (Closed)

Created:
5 years, 8 months ago by Sam Clegg
Modified:
5 years, 8 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -25 lines) Patch
M build_tools/XCompile-nacl.cmake View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ports/jsoncpp/build.sh View 1 chunk +11 lines, -19 lines 0 comments Download
A ports/jsoncpp/nacl.patch View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
M ports/jsoncpp/pkg_info View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sam Clegg
5 years, 8 months ago (2015-04-02 01:09:51 UTC) #2
binji
lgtm https://codereview.chromium.org/1057623004/diff/20001/build_tools/XCompile-nacl.cmake File build_tools/XCompile-nacl.cmake (left): https://codereview.chromium.org/1057623004/diff/20001/build_tools/XCompile-nacl.cmake#oldcode40 build_tools/XCompile-nacl.cmake:40: INCLUDE_DIRECTORIES(${NACL_SDK_ROOT}/include) maybe make this a separate change? It ...
5 years, 8 months ago (2015-04-02 07:39:07 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057623004/20001
5 years, 8 months ago (2015-04-02 16:55:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057623004/20001
5 years, 8 months ago (2015-04-02 17:00:30 UTC) #6
Sam Clegg
Committed patchset #3 (id:40001) manually as 48f3edcfa1ee34685e9086c15aaded76b9411820 (presubmit successful).
5 years, 8 months ago (2015-04-02 17:53:18 UTC) #7
Sam Clegg
5 years, 8 months ago (2015-04-02 17:58:49 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/1057623004/diff/20001/build_tools/XCompile-na...
File build_tools/XCompile-nacl.cmake (left):

https://codereview.chromium.org/1057623004/diff/20001/build_tools/XCompile-na...
build_tools/XCompile-nacl.cmake:40:
INCLUDE_DIRECTORIES(${NACL_SDK_ROOT}/include)
On 2015/04/02 07:39:07, binji wrote:
> maybe make this a separate change? It potentially affects much more than
jsoncpp

Indeed this change does effect other packages, but its also an essential part of
this change.  I'm happy with the trybot coverage in this case.

https://codereview.chromium.org/1057623004/diff/20001/ports/jsoncpp/nacl.patch
File ports/jsoncpp/nacl.patch (right):

https://codereview.chromium.org/1057623004/diff/20001/ports/jsoncpp/nacl.patc...
ports/jsoncpp/nacl.patch:10: +  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}
-std=gnu++11 -Wall")
On 2015/04/02 07:39:07, binji wrote:
> TODO here? We could remove this when we kill the GCC toolchains

Done.

https://codereview.chromium.org/1057623004/diff/20001/ports/jsoncpp/nacl.patc...
ports/jsoncpp/nacl.patch:39: +#if !(defined(__native_client__) &&
defined(__i386__))
On 2015/04/02 07:39:07, binji wrote:
> Add TODO explaining this test failure?

Done.

Powered by Google App Engine
This is Rietveld 408576698