Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1057613006: Use networkingPrivate.getDeviceState in Internet Settings (Closed)

Created:
5 years, 8 months ago by stevenjb
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use networkingPrivate.getDeviceState in Internet Settings BUG=465418 Committed: https://crrev.com/708c18ce94e9be5cf435ba5374552c604d10e5a6 Cr-Commit-Position: refs/heads/master@{#325476}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 4

Patch Set 3 : Rebase + WS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -68 lines) Patch
M chrome/browser/resources/options/chromeos/network_list.js View 1 2 9 chunks +84 lines, -42 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 3 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
stevenjb
5 years, 8 months ago (2015-04-10 16:39:25 UTC) #2
stevenjb
ping
5 years, 8 months ago (2015-04-14 18:30:04 UTC) #3
pneubeck (no reviews)
lgtm https://codereview.chromium.org/1057613006/diff/20001/chrome/browser/resources/options/chromeos/network_list.js File chrome/browser/resources/options/chromeos/network_list.js (right): https://codereview.chromium.org/1057613006/diff/20001/chrome/browser/resources/options/chromeos/network_list.js#newcode66 chrome/browser/resources/options/chromeos/network_list.js:66: nit: remove empty line https://codereview.chromium.org/1057613006/diff/20001/chrome/browser/resources/options/chromeos/network_list.js#newcode1090 chrome/browser/resources/options/chromeos/network_list.js:1090: var type ...
5 years, 8 months ago (2015-04-15 08:13:06 UTC) #4
stevenjb
https://codereview.chromium.org/1057613006/diff/20001/chrome/browser/resources/options/chromeos/network_list.js File chrome/browser/resources/options/chromeos/network_list.js (right): https://codereview.chromium.org/1057613006/diff/20001/chrome/browser/resources/options/chromeos/network_list.js#newcode66 chrome/browser/resources/options/chromeos/network_list.js:66: On 2015/04/15 08:13:06, pneubeck wrote: > nit: remove empty ...
5 years, 8 months ago (2015-04-16 17:07:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057613006/40001
5 years, 8 months ago (2015-04-16 17:08:30 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-16 18:13:41 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 18:14:26 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/708c18ce94e9be5cf435ba5374552c604d10e5a6
Cr-Commit-Position: refs/heads/master@{#325476}

Powered by Google App Engine
This is Rietveld 408576698