Issue 1057613003: Code cleanup in GenerateRecordCallTarget.

Issue 1057613003: Code cleanup in GenerateRecordCallTarget. (Closed)

Created:
5 years, 8 months ago by mvstanton

Modified:
5 years, 8 months ago

Reviewers:
Erik Corry Chromium.org, Toon Verwaest

CC:
Toon Verwaest, v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Code cleanup in GenerateRecordCallTarget. BUG= Committed: https://crrev.com/6a222b8ff033eb523149794d37c0d0f29bc8fc40 Cr-Commit-Position: refs/heads/master@{#27630}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -31 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1	4 chunks	+6 lines, -5 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.cc	View	1	3 chunks	+7 lines, -5 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	3 chunks	+8 lines, -5 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1	4 chunks	+6 lines, -5 lines	0 comments	Download
M	src/mips64/code-stubs-mips64.cc	View	1	4 chunks	+6 lines, -5 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	3 chunks	+8 lines, -6 lines	0 comments	Download

Total messages: 9 (3 generated)

mvstanton

Hi Erik, per your comments, thx for the look, --Michael

5 years, 8 months ago (2015-04-02 15:08:51 UTC) #2

mvstanton

Hi Toon, adding you as reviewer. Erik identified some improvements to my previous CL and ...

5 years, 8 months ago (2015-04-07 12:47:46 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057613003/20001

5 years, 8 months ago (2015-04-07 12:56:26 UTC) #7

commit-bot: I haz the power

5 years, 8 months ago (2015-04-07 13:39:51 UTC) #9

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/6a222b8ff033eb523149794d37c0d0f29bc8fc40
Cr-Commit-Position: refs/heads/master@{#27630}