[Effen] Only skip rows we're showing, when skipping past the rows that we've scrolled beyond in the…

[Effen] Only skip rows we're showing, when skipping past the rows that we've scrolled beyond in the stock list.

Currently, if you then scroll down N items with a filter set, we select which
stock to show by taking the entire list of stocks, skipping the first N, then
filtering the list, then selecting as many stocks as needed to fill the list.

So suppose the list is A, B, Cx, Dx, Ex, F, and the filter is "x", and you've
scrolled down 1 item.

Currently we'd show Cx, Dx, Ex.

Scroll down 1 again.

We still show Cx, Dx, Ex.

What we _should_ show is Dx, Ex if you've scrolled down 1, and just Ex if you've
scrolled two.

This patch fixes this. We now skip rows _after_ filtering. This fixes
the bug whereby if you set a filter then fling the list, we show the
same item over and over as if in a loop.

R=eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/ec7a08c8031612827793fa84611f6e037af5d7f3

[eseidel, 2015-04-20 23:25:07]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2015-04-20 23:25:07]

What is the effect of this change?

[Hixie, 2015-04-20 23:32:02]

On 2015/04/20 at 23:25:07, eseidel wrote:
> What is the effect of this change?

Currently, if you then scroll down N items with a filter set, we select which
stock to show by taking the entire list of stocks, skipping the first N, then
filtering the list, then selecting as many stocks as needed to fill the list.

So suppose the list is A, B, Cx, Dx, Ex, F, and the filter is "x", and you've
scrolled down 1 item.

Currently we'd show Cx, Dx, Ex.

Scroll down 1 again.

We still show Cx, Dx, Ex.

What we _should_ show is Dx, Ex if you've scrolled down 1, and just Ex if you've
scrolled two.

This patch fixes this. We now skip rows _after_ filtering.

[Hixie, 2015-04-20 23:32:51]

(this fixes the bug whereby if you set a filter then fling the list, we show the
same item over and over as if in a loop)

[eseidel, 2015-04-20 23:33:38]

Assuming you update the description to describe what the effect of this bug is,
lgtm. :)

[Hixie, 2015-04-20 23:35:53]

Committed patchset #1 (id:1) manually as
ec7a08c8031612827793fa84611f6e037af5d7f3 (presubmit successful).