bluetooth: Refactor (Add|Remove)Observer impls into BluetoothAdapter.

bluetooth: Refactor (Add|Remove)Observer impls into BluetoothAdapter.

In preparation before BluetoothAdapterAndroid impl, move duplicate
implementation of AddObserver, RemoveObserver into the BluetoothAdapter
base class.

BUG=471536
Committed: https://crrev.com/ea2a85a9ddbdf1cd01362886a89d070b37d10d8b
Cr-Commit-Position: refs/heads/master@{#326186}

[scheib, 2015-04-20 22:23:55]

scheib@chromium.org changed reviewers:
+ armansito@chromium.org

[armansito, 2015-04-20 22:49:18]

Why is the base URL not master? Also, you'll need to modify
mock_bluetooth_adapter now since it doesn't have to override these any more.

[scheib, 2015-04-21 00:28:46]

Patchset #2 (id:20001) has been deleted

[scheib, 2015-04-21 00:51:57]

On 2015/04/20 22:49:18, armansito wrote:
> Why is the base URL not master? 

The patch is parented to the refactoring cleanups.
https://codereview.chromium.org/1100483005/
https://codereview.chromium.org/1096183003/

> Also, you'll need to modify
> mock_bluetooth_adapter now since it doesn't have to override these any more.

The mocked methods are used to verify calls in a few tests, which seems
reasonable to do if we expect observers to be removed and and to verify that.

[armansito, 2015-04-21 23:05:51]

On 2015/04/21 00:51:57, scheib wrote:
> On 2015/04/20 22:49:18, armansito wrote:
> > Why is the base URL not master? 
> 
> The patch is parented to the refactoring cleanups.
> https://codereview.chromium.org/1100483005/
> https://codereview.chromium.org/1096183003/
> 
> > Also, you'll need to modify
> > mock_bluetooth_adapter now since it doesn't have to override these any more.
> 
> The mocked methods are used to verify calls in a few tests, which seems
> reasonable to do if we expect observers to be removed and and to verify that.

Fair enough. I think we initially had them because we HAD to have them, since
the methods were declared as pure virtual. Not sure why we declared them as
mocks. lgtm

[scheib, 2015-04-21 23:18:47]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2015-04-21 23:21:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1057603004/40001

[scheib, 2015-04-21 23:21:53]

The CQ bit was unchecked by scheib@chromium.org

[scheib, 2015-04-21 23:34:59]

Patchset #3 (id:60001) has been deleted

[scheib, 2015-04-21 23:35:15]

The CQ bit was checked by scheib@chromium.org

[scheib, 2015-04-21 23:35:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
armansito@chromium.org
Link to the patchset: https://codereview.chromium.org/1057603004/#ps80001
(title: "Merge TOT")

[commit-bot: I haz the power, 2015-04-21 23:36:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1057603004/80001

[commit-bot: I haz the power, 2015-04-22 00:35:45]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-04-22 00:36:31]

Patchset 3 (id:??) landed as
https://crrev.com/ea2a85a9ddbdf1cd01362886a89d070b37d10d8b
Cr-Commit-Position: refs/heads/master@{#326186}