Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Unified Diff: mojo/shell/command_line_util_unittest.cc

Issue 1057603003: Simplify mojo_shell since it's now only used for Mandoline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update scripts Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/command_line_util.cc ('k') | mojo/shell/context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/command_line_util_unittest.cc
diff --git a/mojo/shell/command_line_util_unittest.cc b/mojo/shell/command_line_util_unittest.cc
deleted file mode 100644
index 547aa8601533f8ae1caf565bf470c3024fe5fe4a..0000000000000000000000000000000000000000
--- a/mojo/shell/command_line_util_unittest.cc
+++ /dev/null
@@ -1,83 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "mojo/shell/command_line_util.h"
-
-#include "base/logging.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace mojo {
-namespace shell {
-namespace {
-
-TEST(CommandLineUtil, ParseArgsFor) {
- static const struct Expectation {
- const char* args;
- const char* value;
- } EXPECTATIONS[] = {
- {"", nullptr},
- {"hello", nullptr},
- {"args-for=mojo:app1", nullptr},
- {"--args-for", nullptr},
- {"--args-for=", ""},
- {"--args-for=mojo:app1", "mojo:app1"},
- {"--args-for=mojo:app1 hello world", "mojo:app1 hello world"},
- {"-args-for", nullptr},
- {"-args-for=", ""},
- {"-args-for=mojo:app1", "mojo:app1"},
- {"-args-for=mojo:app1 hello world", "mojo:app1 hello world"}};
- for (auto& expectation : EXPECTATIONS) {
- std::string value;
- bool result = ParseArgsFor(expectation.args, &value);
- EXPECT_EQ(bool(expectation.value), result);
- if (expectation.value && result)
- EXPECT_EQ(value, expectation.value);
- }
-}
-
-TEST(CommandLineUtil, GetAppURLAndArgs) {
- const char* NO_ARGUMENTS[] = {nullptr};
- const char* ONE_ARGUMENTS[] = {"1", nullptr};
- const char* TWO_ARGUMENTS[] = {"1", "two", nullptr};
- static const struct Expectation {
- const char* args;
- const char* url;
- const char** values;
- } EXPECTATIONS[] = {
- {"", nullptr, nullptr},
- {"foo", "file:///root/foo", NO_ARGUMENTS},
- {"/foo", "file:///foo", NO_ARGUMENTS},
- {"file:foo", "file:///root/foo", NO_ARGUMENTS},
- {"file:///foo", "file:///foo", NO_ARGUMENTS},
- {"http://example.com", "http://example.com", NO_ARGUMENTS},
- {"http://example.com 1", "http://example.com", ONE_ARGUMENTS},
- {"http://example.com 1 ", "http://example.com", ONE_ARGUMENTS},
- {"http://example.com 1 ", "http://example.com", ONE_ARGUMENTS},
- {"http://example.com 1 two", "http://example.com", TWO_ARGUMENTS},
- {" http://example.com 1 two ",
- "http://example.com",
- TWO_ARGUMENTS}};
- Context context;
- context.SetCommandLineCWD(base::FilePath(FILE_PATH_LITERAL("/root")));
- for (auto& expectation : EXPECTATIONS) {
- std::vector<std::string> args;
- GURL result(GetAppURLAndArgs(&context, expectation.args, &args));
- EXPECT_EQ(bool(expectation.url), result.is_valid());
- if (expectation.url && result.is_valid()) {
- EXPECT_EQ(GURL(expectation.url), result);
- std::vector<std::string> expected_args;
- if (expectation.values) {
- if (*expectation.values)
- expected_args.push_back(expectation.url);
- for (const char** value = expectation.values; *value; ++value)
- expected_args.push_back(*value);
- }
- EXPECT_EQ(expected_args, args);
- }
- }
-}
-
-} // namespace
-} // namespace shell
-} // namespace mojo
« no previous file with comments | « mojo/shell/command_line_util.cc ('k') | mojo/shell/context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698