LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-consume-deltas.html - Issue 1057603002: Expose scroll customization for touch to JS (behind REF).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-consume-deltas.html

Issue 1057603002: Expose scroll customization for touch to JS (behind REF). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address haraken's comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html ('k') | LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-consume-deltas-throw.html » ('j') | Source/bindings/core/v8/ScrollStateCallbackToScriptValue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-consume-deltas.html

diff --git a/LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-consume-deltas.html b/LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-consume-deltas.html

index ec328003a093aec3ab6c97680eb0ffc6811ce9e5..f37b597e89b3dc0ffa2dfa339d26f8ba18f95177 100644

--- a/LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-consume-deltas.html

+++ b/LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-consume-deltas.html

@@ -8,12 +8,6 @@

<body>

-if (!window.internals || !window.internals.runtimeFlags.scrollCustomizationEnabled) {

- console.log("These tests only work with window.internals exposed, " +

- "and require scroll customization.");

- done();

function deltaShouldBe(scrollState, x, y, testName) {

test(function() {

assert_equals(scrollState.deltaX, x);

@@ -21,12 +15,18 @@ function deltaShouldBe(scrollState, x, y, testName) {

}, testName);

}

-var scrollState = new ScrollState(10, -20);

-deltaShouldBe(scrollState, 10, -20, "Unconsumed deltas");

-scrollState.consumeDelta(2, -3);

-deltaShouldBe(scrollState, 8, -17, "Partially consumed deltas");

-scrollState.consumeDelta(8, -17);

-deltaShouldBe(scrollState, 0, 0, "Fully consumed deltas");

+test(function() {

+ assert_true('ScrollState' in window, "'ScrollState' in window");

+}, "These tests only work with scroll customization enabled.");

+if ('ScrollState' in window) {

+ var scrollState = new ScrollState(10, -20);

+ deltaShouldBe(scrollState, 10, -20, "Unconsumed deltas");

+ scrollState.consumeDelta(2, -3);

+ deltaShouldBe(scrollState, 8, -17, "Partially consumed deltas");

+ scrollState.consumeDelta(8, -17);

+ deltaShouldBe(scrollState, 0, 0, "Fully consumed deltas");

</script>

</body>

</html>