Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: content/child/notifications/notification_manager.cc

Issue 1057573002: Implement the ability to get all notifications in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-db-Integrate
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/notifications/notification_manager.cc
diff --git a/content/child/notifications/notification_manager.cc b/content/child/notifications/notification_manager.cc
index 29a32323fc8f5d78ef57fd9251422443123d17e5..b17611d0e35929e2da73c5e6e88fda5de127eeeb 100644
--- a/content/child/notifications/notification_manager.cc
+++ b/content/child/notifications/notification_manager.cc
@@ -280,8 +280,11 @@ void NotificationManager::OnDidGetNotifications(
for (size_t i = 0; i < notification_infos.size(); ++i) {
blink::WebPersistentNotificationInfo web_notification_info;
+
+ // TODO(peter): Stop converting the notification id to a string when the
+ // Blink API has been updated to support integral ids.
web_notification_info.persistentNotificationId =
- blink::WebString::fromUTF8(notification_infos[i].first);
+ base::Int64ToString16(notification_infos[i].first);
web_notification_info.data =
ToWebNotificationData(notification_infos[i].second);

Powered by Google App Engine
This is Rietveld 408576698