Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1057573002: Implement the ability to get all notifications in Chromium. (Closed)

Created:
5 years, 8 months ago by Peter Beverloo
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, peter+watch_chromium.org, jam, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@n-db-Integrate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement the ability to get all notifications in Chromium. This patch implements the SWR.getNotifications() API in Chromium, by hooking it up to the Notification database. All functionality, including the filter-by-tag option, are supported. This CL is part of a two-sided patch: [1] This CL. [2] https://codereview.chromium.org/1056573002/ BUG=442143 Committed: https://crrev.com/08f04f149112e624606dda88d63951942348c5a4 Cr-Commit-Position: refs/heads/master@{#325626}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : include uma #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -9 lines) Patch
M content/browser/notifications/notification_message_filter.h View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M content/browser/notifications/notification_message_filter.cc View 1 2 3 1 chunk +35 lines, -5 lines 0 comments Download
M content/browser/notifications/platform_notification_context_impl.h View 2 chunks +12 lines, -0 lines 0 comments Download
M content/browser/notifications/platform_notification_context_impl.cc View 1 2 2 chunks +55 lines, -2 lines 0 comments Download
M content/browser/notifications/platform_notification_context_unittest.cc View 3 chunks +83 lines, -0 lines 0 comments Download
M content/public/browser/platform_notification_context.h View 3 chunks +14 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
Peter Beverloo
+johnme for notifications This CL depends on: https://codereview.chromium.org/1026853002/
5 years, 8 months ago (2015-04-01 16:32:19 UTC) #2
johnme
lgtm with nit, thanks :) https://codereview.chromium.org/1057573002/diff/20001/content/browser/notifications/platform_notification_context_impl.cc File content/browser/notifications/platform_notification_context_impl.cc (right): https://codereview.chromium.org/1057573002/diff/20001/content/browser/notifications/platform_notification_context_impl.cc#newcode147 content/browser/notifications/platform_notification_context_impl.cc:147: // TODO(peter): Record UMA ...
5 years, 8 months ago (2015-04-08 18:12:41 UTC) #3
Peter Beverloo
Done! +askvitkine and rkaplow for UMA additions https://codereview.chromium.org/1057573002/diff/20001/content/browser/notifications/platform_notification_context_impl.cc File content/browser/notifications/platform_notification_context_impl.cc (right): https://codereview.chromium.org/1057573002/diff/20001/content/browser/notifications/platform_notification_context_impl.cc#newcode147 content/browser/notifications/platform_notification_context_impl.cc:147: // TODO(peter): ...
5 years, 8 months ago (2015-04-14 18:01:28 UTC) #5
Peter Beverloo
+avi for //content/public/ (API will be used by PushMessagingServiceImpl.) +askvitkine, rkaplow for histogram addition.
5 years, 8 months ago (2015-04-16 17:03:02 UTC) #7
Peter Beverloo
-askvitkine, +asvitkine The askvitkine account is a bit confusing..
5 years, 8 months ago (2015-04-16 17:04:14 UTC) #9
Peter Beverloo
5 years, 8 months ago (2015-04-16 17:05:06 UTC) #11
Alexei Svitkine (slow)
lgtm
5 years, 8 months ago (2015-04-16 17:06:52 UTC) #12
Avi (use Gerrit)
content api lgtm
5 years, 8 months ago (2015-04-16 18:53:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057573002/60001
5 years, 8 months ago (2015-04-17 11:01:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057573002/60001
5 years, 8 months ago (2015-04-17 12:58:28 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-17 13:52:40 UTC) #20
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 13:53:26 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/08f04f149112e624606dda88d63951942348c5a4
Cr-Commit-Position: refs/heads/master@{#325626}

Powered by Google App Engine
This is Rietveld 408576698