Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1057553004: [DevTools] Fix crash in DevToolsWindow::ActivateContents. (Closed)

Created:
5 years, 8 months ago by dgozman
Modified:
5 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, aandrey+blink_chromium.org, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix crash in DevToolsWindow::ActivateContents. BUG=475484 Committed: https://crrev.com/b91be0ebbb4f38e76201c665a47fb1c562c8aa16 Cr-Commit-Position: refs/heads/master@{#325655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/devtools/devtools_window.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dgozman
Take a look please.
5 years, 8 months ago (2015-04-16 10:42:51 UTC) #2
pfeldman
lgtm
5 years, 8 months ago (2015-04-17 15:58:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057553004/1
5 years, 8 months ago (2015-04-17 16:01:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 17:01:31 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 17:02:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b91be0ebbb4f38e76201c665a47fb1c562c8aa16
Cr-Commit-Position: refs/heads/master@{#325655}

Powered by Google App Engine
This is Rietveld 408576698