Convert browser_tests to Swarming.

Convert browser_tests to Swarming.

Ran:
  ./manage.py --convert browser_tests

R=phajdan.jr@chromium.org
BUG=98637
Committed: https://crrev.com/3fc0b045cc2aa9f9afa1716d36c32c965de5e4d0
Cr-Commit-Position: refs/heads/master@{#335669}

[M-A Ruel, 2015-04-01 15:50:03]

- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.fyi.json: CrWinClangLLD tester
- chromium.fyi.json: Linux Trusty
- chromium.fyi.json: Linux Trusty (dbg)

[Timur Iskhodzhanov, 2015-04-01 16:48:28]

timurrrr@chromium.org changed reviewers:
+ timurrrr@chromium.org

[Timur Iskhodzhanov, 2015-04-01 16:48:29]

Nico and Hans might have some insight re: swarming on the ASan+LLD bots

[hans, 2015-04-01 16:52:46]

On 2015/04/01 16:48:29, Timur Iskhodzhanov wrote:
> Nico and Hans might have some insight re: swarming on the ASan+LLD bots

We already use swarming on the other WinClang bots, and I can't recall any
reason why it wouldn't work for ASan bots too.

lgtm if it works, I guess :)

[Timur Iskhodzhanov, 2015-04-01 17:11:06]

Off the top of my head I can recall
https://code.google.com/p/chromium/issues/detail?id=457820

I have a vague memory of something else being wrong with swarming...
Please wait for Nico to take a look.

[Nico, 2015-04-01 18:27:56]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-04-01 18:27:56]

We don't set fastbuild=1 on the win/asan bots (see discussion in
https://codereview.chromium.org/915453002/), so even if stacks worked I think
the clang/asan bots would run into
https://code.google.com/p/chromium/issues/detail?id=419862

So we shouldn't do this on the clang/asan bots, I think.

[M-A Ruel, 2015-04-01 20:25:02]

On 2015/04/01 18:27:56, Nico wrote:
> We don't set fastbuild=1 on the win/asan bots (see discussion in
> https://codereview.chromium.org/915453002/), so even if stacks worked I think
> the clang/asan bots would run into
> https://code.google.com/p/chromium/issues/detail?id=419862
> 
> So we shouldn't do this on the clang/asan bots, I think.

To double-check I understood correctly. Nico, you want me to update manage.py to
blacklist all WinASan builders?

[Nico, 2015-04-01 20:26:06]

I don't know what manage.py is, so no idea.

On Wed, Apr 1, 2015 at 1:25 PM, <maruel@chromium.org> wrote:

> On 2015/04/01 18:27:56, Nico wrote:
>
>> We don't set fastbuild=1 on the win/asan bots (see discussion in
>> https://codereview.chromium.org/915453002/), so even if stacks worked I
>> think
>> the clang/asan bots would run into
>> https://code.google.com/p/chromium/issues/detail?id=419862
>>
>
>  So we shouldn't do this on the clang/asan bots, I think.
>>
>
> To double-check I understood correctly. Nico, you want me to update
> manage.py to
> blacklist all WinASan builders?
>
> https://codereview.chromium.org/1057553002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Paweł Hajdan Jr., 2015-04-02 09:59:51]

phajdan.jr@chromium.org changed reviewers:
+ hans@chromium.org

[Paweł Hajdan Jr., 2015-04-02 09:59:51]

LGTM

[M-A Ruel, 2015-04-02 12:58:42]

> On Wed, Apr 1, 2015 at 1:25 PM, <mailto:maruel@chromium.org> wrote:
> > To double-check I understood correctly. Nico, you want me to update
> > manage.py to
> > blacklist all WinASan builders?

On 2015/04/01 20:26:06, Nico (again away until Monday) wrote:
> I don't know what manage.py is, so no idea.

It's the script I added in this directory to convert a test from run locally on
all buildbot slaves to be run on Swarming. So my question is do you want to not
run tests on Swarming for "CrWinAsan tester", "CrWinAsan(dll) tester".

In that case, would it be a good idea could be to disable swarming at the recipe
level?

[Nico, 2015-04-02 13:48:24]

We might want swarming for browser tests once the isolate step doesn't die
with oom. But until then we don't want to swarm browser tests.
On Apr 2, 2015 5:58 AM, <maruel@chromium.org> wrote:

> On Wed, Apr 1, 2015 at 1:25 PM, <mailto:maruel@chromium.org> wrote:
>> > To double-check I understood correctly. Nico, you want me to update
>> > manage.py to
>> > blacklist all WinASan builders?
>>
>
> On 2015/04/01 20:26:06, Nico (again away until Monday) wrote:
>
>> I don't know what manage.py is, so no idea.
>>
>
> It's the script I added in this directory to convert a test from run
> locally on
> all buildbot slaves to be run on Swarming. So my question is do you want
> to not
> run tests on Swarming for "CrWinAsan tester", "CrWinAsan(dll) tester".
>
> In that case, would it be a good idea could be to disable swarming at the
> recipe
> level?
>
> https://codereview.chromium.org/1057553002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[M-A Ruel, 2015-06-04 20:13:59]

On 2015/04/02 13:48:24, Nico wrote:
> We might want swarming for browser tests once the isolate step doesn't die
> with oom. But until then we don't want to swarm browser tests.

We're getting there.

[M-A Ruel, 2015-06-22 20:37:57]

Similar to https://codereview.chromium.org/1052723002, I rebased this CL and
will commit tomorrow morning.

Once both cleared out, I'll rush on the remainder, as in theory the rest will be
somewhat uneventful and most importantly can be done/reverted concurrently.

[M-A Ruel, 2015-06-23 14:03:58]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2015-06-23 14:03:58]

The patchset sent to the CQ was uploaded after l-g-t-m from hans@chromium.org,
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/1057553002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2015-06-23 14:04:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1057553002/20001

[commit-bot: I haz the power, 2015-06-23 15:12:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-23 15:12:47]

Patchset 2 (id:??) landed as
https://crrev.com/3fc0b045cc2aa9f9afa1716d36c32c965de5e4d0
Cr-Commit-Position: refs/heads/master@{#335669}