tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py - Issue 105753006: Revert "Revert 239784 "Make page_cycler.py fully measure memory for each...""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py

Issue 105753006: Revert "Revert 239784 "Make page_cycler.py fully measure memory for each..."" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address Shadi's comment Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py

index 3bfbf06005bd61796291a91243ea93375d85c0d6..bbcb2090c1c03d898b6de675baf4231ee146038a 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py

@@ -99,7 +99,7 @@ class TCPDumpProfiler(profiler.Profiler):

browser_backend, platform_backend, output_path, state)

if platform_backend.GetOSName() == 'android':

android_prebuilt_profiler_helper.InstallOnDevice(

- browser_backend.adb, 'tcpdump')

+ browser_backend.adb.Adb(), 'tcpdump')

self._platform_profiler = _TCPDumpProfilerAndroid(

browser_backend.adb, output_path)

else:

« no previous file with comments | « tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py ('k') | no next file » | no next file with comments »