tools/perf/measurements/page_cycler.py - Issue 105753006: Revert "Revert 239784 "Make page_cycler.py fully measure memory for each...""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/page_cycler.py

Issue 105753006: Revert "Revert 239784 "Make page_cycler.py fully measure memory for each..."" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address Shadi's comment Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/page_cycler.py

diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py

index 2daccb38c266da3a07b1e98a5d2addec4d620708..2dd22d04918c7790453b69013531889d4dc2426f 100644

--- a/tools/perf/measurements/page_cycler.py

+++ b/tools/perf/measurements/page_cycler.py

@@ -164,7 +164,6 @@ class PageCycler(page_measurement.PageMeasurement):

tab, results, chart_name=chart_name_prefix+'speed_index')

def DidRunTest(self, browser, results):

- self._memory_metric.AddSummaryResults(results)

io.IOMetric().AddSummaryResults(browser, results)

def IsRunCold(self, url):

« no previous file with comments | « tools/perf/measurements/memory_multi_tab.py ('k') | tools/perf/metrics/memory.py » ('j') | no next file with comments »