tools/perf/measurements/memory_multi_tab.py - Issue 105753006: Revert "Revert 239784 "Make page_cycler.py fully measure memory for each...""

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/measurements/memory_multi_tab.py

Issue 105753006: Revert "Revert 239784 "Make page_cycler.py fully measure memory for each..."" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address Shadi's comment Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Multi tab memory test.	5 """Multi tab memory test.

6	6

7 This test is a multi tab test, but we're interested in measurements for	7 This test is a multi tab test, but we're interested in measurements for

8 the entire test rather than each single page.	8 the entire test rather than each single page.

9 """	9 """

10	10

(...skipping 24 matching lines...) Expand all Loading...
35 # Start measurement on the first tab.	35 # Start measurement on the first tab.

36 if not self._first_tab:	36 if not self._first_tab:

37 self._memory_metric.Start(page, tab)	37 self._memory_metric.Start(page, tab)

38 self._first_tab = tab	38 self._first_tab = tab

39	39

40 def MeasurePage(self, page, tab, results):	40 def MeasurePage(self, page, tab, results):

41 # Finalize measurement on the last tab.	41 # Finalize measurement on the last tab.

42 if len(tab.browser.tabs) == len(page.page_set.pages):	42 if len(tab.browser.tabs) == len(page.page_set.pages):

43 self._memory_metric.Stop(page, self._first_tab)	43 self._memory_metric.Stop(page, self._first_tab)

44 self._memory_metric.AddResults(self._first_tab, results)	44 self._memory_metric.AddResults(self._first_tab, results)

45

46 def DidRunTest(self, browser, results):

47 self._memory_metric.AddSummaryResults(results)

OLD	NEW

« no previous file with comments | « tools/perf/measurements/memory.py ('k') | tools/perf/measurements/page_cycler.py » ('j') | no next file with comments »