Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: tools/perf/measurements/memory.py

Issue 105753006: Revert "Revert 239784 "Make page_cycler.py fully measure memory for each..."" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Shadi's comment Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/perf/measurements/media.py ('k') | tools/perf/measurements/memory_multi_tab.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from metrics import memory 5 from metrics import memory
6 from telemetry.page import page_measurement 6 from telemetry.page import page_measurement
7 7
8 class Memory(page_measurement.PageMeasurement): 8 class Memory(page_measurement.PageMeasurement):
9 def __init__(self): 9 def __init__(self):
10 super(Memory, self).__init__('stress_memory') 10 super(Memory, self).__init__('stress_memory')
(...skipping 22 matching lines...) Expand all
33 # The tcmalloc_heap_profiler dumps files at regular 33 # The tcmalloc_heap_profiler dumps files at regular
34 # intervals (~20 secs). 34 # intervals (~20 secs).
35 # This is a minor optimization to ensure it'll dump the last file when 35 # This is a minor optimization to ensure it'll dump the last file when
36 # the test completes. 36 # the test completes.
37 tab.ExecuteJavaScript(""" 37 tab.ExecuteJavaScript("""
38 if (chrome && chrome.memoryBenchmarking) { 38 if (chrome && chrome.memoryBenchmarking) {
39 chrome.memoryBenchmarking.heapProfilerDump('renderer', 'final'); 39 chrome.memoryBenchmarking.heapProfilerDump('renderer', 'final');
40 chrome.memoryBenchmarking.heapProfilerDump('browser', 'final'); 40 chrome.memoryBenchmarking.heapProfilerDump('browser', 'final');
41 } 41 }
42 """) 42 """)
43
44 def DidRunTest(self, browser, results):
45 self._memory_metric.AddSummaryResults(results)
OLDNEW
« no previous file with comments | « tools/perf/measurements/media.py ('k') | tools/perf/measurements/memory_multi_tab.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698