Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 105753003: Generate toSVGGradient|Graphics|PolyElement() (Closed)

Created:
7 years ago by gyuyoung-inactive
Modified:
7 years ago
Reviewers:
tkent
CC:
blink-reviews, pdr, Stephen Chennney, krit, f(malita), rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Generate toSVGGradient|Graphics|PolyElement() This cl generate toSVGFoo() for SVGGradientElement, SVGGraphicsElement, and SVGPolyElement(). We can use more plenty toSVGFoo() functions, and help to detect bad type casts. BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M Source/core/svg/SVGGradientElement.h View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPolyElement.h View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gyuyoung-inactive
7 years ago (2013-12-05 01:46:46 UTC) #1
tkent
lgtm
7 years ago (2013-12-05 01:51:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/105753003/1
7 years ago (2013-12-05 01:51:29 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-05 03:33:49 UTC) #4
Message was sent while issue was closed.
Change committed as 163215

Powered by Google App Engine
This is Rietveld 408576698