Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1057493005: Revert of base: Replace PurgeAndTruncate with Shrink function. (Closed)

Created:
5 years, 8 months ago by reveman
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, gavinp+memory_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of base: Replace PurgeAndTruncate with Shrink function. (patchset #5 id:80001 of https://codereview.chromium.org/1018743003/) Reason for revert: Suspecting that this might be related to crbug.com/471188. Original issue's description: > base: Replace PurgeAndTruncate with Shrink function. > > This cleans up the API a bit and allows the code to be unit tested. > > This also prevents ftruncate from being used on Android where > shared memory is backed by Ashmem. Ashmem doesn't support ftruncate. > > BUG=466509 > TEST=base_unittests --gtest_filter=DiscardableSharedMemoryTest.Shrink > > Committed: https://crrev.com/2d15df9ef3f9b982aef650d0be0be64a1c5d34a5 > Cr-Commit-Position: refs/heads/master@{#322207} TBR=avi@chromium.org,danakj@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466509 Committed: https://crrev.com/f2580f56cb770069af82eb10e8e2a58a2f4f72d7 Cr-Commit-Position: refs/heads/master@{#323240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -55 lines) Patch
M base/memory/discardable_shared_memory.h View 3 chunks +6 lines, -12 lines 0 comments Download
M base/memory/discardable_shared_memory.cc View 2 chunks +16 lines, -20 lines 0 comments Download
M base/memory/discardable_shared_memory_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M content/common/host_discardable_shared_memory_manager.cc View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reveman
Created Revert of base: Replace PurgeAndTruncate with Shrink function.
5 years, 8 months ago (2015-04-01 15:14:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057493005/1
5 years, 8 months ago (2015-04-01 15:15:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 15:18:33 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 15:20:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2580f56cb770069af82eb10e8e2a58a2f4f72d7
Cr-Commit-Position: refs/heads/master@{#323240}

Powered by Google App Engine
This is Rietveld 408576698