Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1057483003: Handle rewinds in SkBmpCodec. (Closed)

Created:
5 years, 8 months ago by scroggo
Modified:
5 years, 8 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Handle rewinds in SkBmpCodec. Factor our BMP code for reading the header, and call it after a rewind. BUG=skia:3257 Committed: https://skia.googlesource.com/skia/+/79e378d9b78c3db28eb97ab9adecb5bfddbf52d8

Patch Set 1 #

Patch Set 2 : Initialize codec to defeat warning. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -34 lines) Patch
M src/codec/SkCodec_libbmp.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/codec/SkCodec_libbmp.cpp View 1 14 chunks +53 lines, -32 lines 0 comments Download
M tests/CodexTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
scroggo
5 years, 8 months ago (2015-04-01 14:05:37 UTC) #2
msarett
lgtm Thanks for crossing this off my list of things to do!
5 years, 8 months ago (2015-04-01 14:12:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057483003/1
5 years, 8 months ago (2015-04-01 14:16:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/251)
5 years, 8 months ago (2015-04-01 14:17:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057483003/20001
5 years, 8 months ago (2015-04-01 14:32:22 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 14:39:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/79e378d9b78c3db28eb97ab9adecb5bfddbf52d8

Powered by Google App Engine
This is Rietveld 408576698