Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: content/child/permissions/permission_dispatcher_thread_proxy.h

Issue 1057453004: Permissions: glue between Mojo and Blink for permission observing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/permissions/permission_dispatcher_thread_proxy.h
diff --git a/content/child/permissions/permission_dispatcher_thread_proxy.h b/content/child/permissions/permission_dispatcher_thread_proxy.h
index c5273355000bf6d3f271ecf1ece5e8e5f03ad608..037e5483866d2d58ce8f6d68533cca7287a9cbd7 100644
--- a/content/child/permissions/permission_dispatcher_thread_proxy.h
+++ b/content/child/permissions/permission_dispatcher_thread_proxy.h
@@ -5,10 +5,10 @@
#ifndef CONTENT_CHILD_PERMISSIONS_PERMISSION_DISPATCHER_THREAD_PROXY_H_
#define CONTENT_CHILD_PERMISSIONS_PERMISSION_DISPATCHER_THREAD_PROXY_H_
-#include "base/compiler_specific.h"
#include "base/id_map.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
+#include "content/child/permissions/permission_observers_registry.h"
#include "content/child/worker_task_runner.h"
#include "third_party/WebKit/public/platform/modules/permissions/WebPermissionClient.h"
@@ -22,6 +22,7 @@ class PermissionDispatcher;
class PermissionDispatcherThreadProxy :
whywhat 2015/04/02 16:20:24 The class name has the word Thread in it, indicati
mlamouri (slow - plz ping) 2015/04/02 17:02:43 Done.
public blink::WebPermissionClient,
+ public PermissionObserversRegistry,
public WorkerTaskRunner::Observer {
public:
static PermissionDispatcherThreadProxy* GetThreadInstance(
@@ -32,6 +33,10 @@ class PermissionDispatcherThreadProxy :
virtual void queryPermission(blink::WebPermissionType type,
const blink::WebURL& origin,
blink::WebPermissionQueryCallback* callback);
+ virtual void startListening(blink::WebPermissionType type,
+ const blink::WebURL& origin,
+ blink::WebPermissionObserver* observer);
+ virtual void stopListening(blink::WebPermissionObserver* observer);
// WorkerTaskRunner::Observer implementation.
void OnWorkerRunLoopStopped() override;
@@ -41,6 +46,12 @@ class PermissionDispatcherThreadProxy :
base::SingleThreadTaskRunner* main_thread_task_runner,
PermissionDispatcher* permissions_dispatcher);
+ // Callback when an observed permission changes.
+ void OnPermissionChanged(blink::WebPermissionType type,
+ const std::string& origin,
+ blink::WebPermissionObserver* observer,
+ blink::WebPermissionStatus status);
+
virtual ~PermissionDispatcherThreadProxy();
scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner_;

Powered by Google App Engine
This is Rietveld 408576698