Source/bindings/scripts/idl_definitions.py - Issue 1057453002: bindings: Throw TypeError when required dictionary member is undefined

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/idl_definitions.py

Issue 1057453002: bindings: Throw TypeError when required dictionary member is undefined (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/idl_definitions.py

diff --git a/Source/bindings/scripts/idl_definitions.py b/Source/bindings/scripts/idl_definitions.py

index 630bc8482ca3732d97f28478512536b4874ba2bc..25e4d13eebea8f4a01cb3e564609c7c61c5a47e6 100644

--- a/Source/bindings/scripts/idl_definitions.py

+++ b/Source/bindings/scripts/idl_definitions.py

@@ -222,6 +222,7 @@ class IdlDictionaryMember(TypedObject):

self.extended_attributes = {}

self.idl_type = None

self.idl_name = idl_name

+ self.is_required = bool(node.GetProperty('REQUIRED'))

self.name = node.GetName()

for child in node.GetChildren():

child_class = child.GetClass()

« no previous file with comments | « LayoutTests/fast/dom/idl-dictionary-unittest-expected.txt ('k') | Source/bindings/scripts/v8_dictionary.py » ('j') | no next file with comments »