Source/bindings/templates/dictionary_v8.cpp - Issue 1057453002: bindings: Throw TypeError when required dictionary member is undefined

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/dictionary_v8.cpp

Issue 1057453002: bindings: Throw TypeError when required dictionary member is undefined (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/scripts/v8_dictionary.py ('k') | Source/bindings/tests/idls/core/TestDictionaryDerived.idl » ('j') | Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/templates/dictionary_v8.cpp

diff --git a/Source/bindings/templates/dictionary_v8.cpp b/Source/bindings/templates/dictionary_v8.cpp

index c6b6d1343a7b3922a93e49f78d18884ee6347a01..dfd660285bb1e0c2e9d7c8ca2d7dff054badc1a2 100644

--- a/Source/bindings/templates/dictionary_v8.cpp

+++ b/Source/bindings/templates/dictionary_v8.cpp

@@ -46,7 +46,12 @@ void {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, {{

return;

}

if ({{member.name}}Value.IsEmpty() || {{member.name}}Value->IsUndefined()) {

+ {% if member.is_required %}

+ exceptionState.throwTypeError("required member {{member.name}} is undefined.");

+ return;

+ {% else %}

// Do nothing.

+ {% endif %}

{% if member.is_nullable %}

} else if ({{member.name}}Value->IsNull()) {

impl.{{member.null_setter_name}}();