Source/bindings/scripts/interface_dependency_resolver.py - Issue 1057443002: Partial interface should use original interface's cpp_name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/interface_dependency_resolver.py

Issue 1057443002: Partial interface should use original interface's cpp_name. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Another fix Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/interface_dependency_resolver.py

diff --git a/Source/bindings/scripts/interface_dependency_resolver.py b/Source/bindings/scripts/interface_dependency_resolver.py

index f755d878ae24d6bf1de1b00a1751673e7fd550b1..705b8812ef94b567f0d255b0a2af79767b94f093 100644

--- a/Source/bindings/scripts/interface_dependency_resolver.py

+++ b/Source/bindings/scripts/interface_dependency_resolver.py

@@ -185,11 +185,14 @@ def merge_interface_dependencies(definitions, component, target_interface, depen

component))

if dependency_component in resolved_definitions:

+ dependency_interface.extended_attributes.pop('ImplementedAs', None)

bashi 2015/04/02 23:15:27 Without having comment, it's difficult to understa

tasak 2015/04/03 05:22:53 Done.

resolved_definitions[dependency_component].update(dependency_definitions)

continue

dependency_interface.extended_attributes.update(target_interface.extended_attributes)

assert target_interface == definitions.interfaces[dependency_interface.name]

+ if 'ImplementedAs' not in target_interface.extended_attributes:

+ dependency_interface.extended_attributes.pop('ImplementedAs', None)

dependency_interface.original_interface = target_interface

target_interface.partial_interfaces.append(dependency_interface)

resolved_definitions[dependency_component] = dependency_definitions

« no previous file with comments | « no previous file | no next file » | no next file with comments »