Add TrackableCallback in ContentDecryptorDelegate.

Add TrackableCallback in ContentDecryptorDelegate.

The TrackableCallback manages the callback and the request ID so that we don't
need to manage them separately.

Also in this CL:
- Using media::Decryptor in .cc file.
- Renaming: pending_foo_cb_ -> foo_cb_

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243460

[xhwang, 2013-12-28 09:19:41]

A clean-up CL; no functionality change. PTAL

[xhwang, 2013-12-28 09:35:07]

rebase only

[dmichael (off chromium), 2014-01-03 18:44:43]

lgtm

https://codereview.chromium.org/105743010/diff/180001/content/renderer/pepper...
File content/renderer/pepper/content_decryptor_delegate.cc (right):

https://codereview.chromium.org/105743010/diff/180001/content/renderer/pepper...
content/renderer/pepper/content_decryptor_delegate.cc:527: Decryptor::kVideo,
encrypted_buffer, &encrypted_resource)) {
style nit: I would probably put the first two parameters on line 526, assuming
they fit.

But this might be just my taste. If you're using the clang formatter, definitely
ignore this comment. I'm not used to its quirks yet.

https://codereview.chromium.org/105743010/diff/180001/content/renderer/pepper...
File content/renderer/pepper/content_decryptor_delegate.h (right):

https://codereview.chromium.org/105743010/diff/180001/content/renderer/pepper...
content/renderer/pepper/content_decryptor_delegate.h:112: // TODO(xhwang): Check
that no callback is pending in dtor.
That should be an easy check to add if you want it, right? Why not add it now?

[xhwang, 2014-01-07 19:53:30]

https://codereview.chromium.org/105743010/diff/180001/content/renderer/pepper...
File content/renderer/pepper/content_decryptor_delegate.h (right):

https://codereview.chromium.org/105743010/diff/180001/content/renderer/pepper...
content/renderer/pepper/content_decryptor_delegate.h:112: // TODO(xhwang): Check
that no callback is pending in dtor.
On 2014/01/03 18:44:43, dmichael wrote:
> That should be an easy check to add if you want it, right? Why not add it now?

I can't do this now because we didn't always satisfy all callbacks, which is a
bug: https://codereview.chromium.org/116443009/

I'll address this TODO after that bug is fixed.

[ddorwin, 2014-01-07 22:16:26]

lgtm

[xhwang, 2014-01-07 22:40:21]

https://codereview.chromium.org/105743010/diff/180001/content/renderer/pepper...
File content/renderer/pepper/content_decryptor_delegate.cc (right):

https://codereview.chromium.org/105743010/diff/180001/content/renderer/pepper...
content/renderer/pepper/content_decryptor_delegate.cc:527: Decryptor::kVideo,
encrypted_buffer, &encrypted_resource)) {
On 2014/01/03 18:44:43, dmichael wrote:
> style nit: I would probably put the first two parameters on line 526, assuming
> they fit.
> 
> But this might be just my taste. If you're using the clang formatter,
definitely
> ignore this comment. I'm not used to its quirks yet.

Yeah, this is done by clang-format. Personally I won't write code like this
either :)

[commit-bot: I haz the power, 2014-01-07 22:42:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/105743010/180001

[commit-bot: I haz the power, 2014-01-08 01:22:28]

Change committed as 243460