Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: gin/wrappable.cc

Issue 105743007: Gin: Make it easier to implement Wrappable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/wrappable.cc
diff --git a/gin/wrappable.cc b/gin/wrappable.cc
index 0338211070af79b655a04895d2114135becd4b35..95ea5af1805fd0bd92f92bd64c3a8afd9faa1eb3 100644
--- a/gin/wrappable.cc
+++ b/gin/wrappable.cc
@@ -9,27 +9,27 @@
namespace gin {
-Wrappable::Wrappable() {
+WrappableBase::WrappableBase() {
}
-Wrappable::~Wrappable() {
+WrappableBase::~WrappableBase() {
wrapper_.Reset();
}
-v8::Handle<v8::Object> Wrappable::GetWrapper(v8::Isolate* isolate) {
+v8::Handle<v8::Object> WrappableBase::GetWrapper(v8::Isolate* isolate) {
if (wrapper_.IsEmpty())
CreateWrapper(isolate);
return v8::Local<v8::Object>::New(isolate, wrapper_);
}
-void Wrappable::WeakCallback(
- const v8::WeakCallbackData<v8::Object, Wrappable>& data) {
- Wrappable* wrappable = data.GetParameter();
+void WrappableBase::WeakCallback(
+ const v8::WeakCallbackData<v8::Object, WrappableBase>& data) {
+ WrappableBase* wrappable = data.GetParameter();
wrappable->wrapper_.Reset();
delete wrappable;
}
-v8::Handle<v8::Object> Wrappable::CreateWrapper(v8::Isolate* isolate) {
+v8::Handle<v8::Object> WrappableBase::CreateWrapper(v8::Isolate* isolate) {
WrapperInfo* info = GetWrapperInfo();
PerIsolateData* data = PerIsolateData::From(isolate);
v8::Local<v8::ObjectTemplate> templ = data->GetObjectTemplate(info);
« gin/wrappable.h ('K') | « gin/wrappable.h ('k') | gin/wrappable_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698