Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: gin/function_template.h

Issue 105743007: Gin: Make it easier to implement Wrappable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gin/function_template.cc » ('j') | gin/wrappable.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/function_template.h
diff --git a/gin/function_template.h b/gin/function_template.h
index 7e33994eedbacf7b9ee79a22ffb0e7c50c0f7c09..37f4065edc0aff7c9715b88eb75d931c0da6195d 100644
--- a/gin/function_template.h
+++ b/gin/function_template.h
@@ -55,10 +55,10 @@ struct CallbackParamTraits<const T*> {
// It inherits from Wrappable, which delete itself when both (a) the refcount
// via base::RefCounted has dropped to zero, and (b) there are no more
// JavaScript references in V8.
-class CallbackHolderBase : public Wrappable {
- public:
- virtual WrapperInfo* GetWrapperInfo() OVERRIDE;
- static WrapperInfo kWrapperInfo;
+
+// This simple base class is used so that we can share a single object template
+// among every CallbackHolder instance.
+class CallbackHolderBase : public Wrappable<CallbackHolderBase> {
protected:
virtual ~CallbackHolderBase() {}
};
« no previous file with comments | « no previous file | gin/function_template.cc » ('j') | gin/wrappable.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698