Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Side by Side Diff: gin/wrappable.cc

Issue 105743007: Gin: Make it easier to implement Wrappable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blah Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gin/wrappable.h" 5 #include "gin/wrappable.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "gin/per_isolate_data.h" 8 #include "gin/per_isolate_data.h"
9 9
10 namespace gin { 10 namespace gin {
11 11
12 Wrappable::Wrappable() { 12 WrapperInfo* WrappableTraitsTest::GetWrapperInfo() {
13 return &WrappableTraits<WrappableTraitsTest>::kWrapperInfo;
13 } 14 }
14 15
15 Wrappable::~Wrappable() { 16 WrappableBase::WrappableBase() {
17 }
18
19 WrappableBase::~WrappableBase() {
16 wrapper_.Reset(); 20 wrapper_.Reset();
17 } 21 }
18 22
19 v8::Handle<v8::Object> Wrappable::GetWrapper(v8::Isolate* isolate) { 23 v8::Handle<v8::Object> WrappableBase::GetWrapper(v8::Isolate* isolate) {
20 if (wrapper_.IsEmpty()) 24 if (wrapper_.IsEmpty())
21 CreateWrapper(isolate); 25 CreateWrapper(isolate);
22 return v8::Local<v8::Object>::New(isolate, wrapper_); 26 return v8::Local<v8::Object>::New(isolate, wrapper_);
23 } 27 }
24 28
25 void Wrappable::WeakCallback( 29 void WrappableBase::WeakCallback(
26 const v8::WeakCallbackData<v8::Object, Wrappable>& data) { 30 const v8::WeakCallbackData<v8::Object, WrappableBase>& data) {
27 Wrappable* wrappable = data.GetParameter(); 31 WrappableBase* wrappable = data.GetParameter();
28 wrappable->wrapper_.Reset(); 32 wrappable->wrapper_.Reset();
29 delete wrappable; 33 delete wrappable;
30 } 34 }
31 35
32 v8::Handle<v8::Object> Wrappable::CreateWrapper(v8::Isolate* isolate) { 36 v8::Handle<v8::Object> WrappableBase::CreateWrapper(v8::Isolate* isolate) {
33 WrapperInfo* info = GetWrapperInfo(); 37 WrapperInfo* info = GetWrapperInfo();
34 PerIsolateData* data = PerIsolateData::From(isolate); 38 PerIsolateData* data = PerIsolateData::From(isolate);
35 v8::Local<v8::ObjectTemplate> templ = data->GetObjectTemplate(info); 39 v8::Local<v8::ObjectTemplate> templ = data->GetObjectTemplate(info);
36 CHECK(!templ.IsEmpty()); // Don't forget to register an object template. 40 CHECK(!templ.IsEmpty()); // Don't forget to register an object template.
37 CHECK_EQ(kNumberOfInternalFields, templ->InternalFieldCount()); 41 CHECK_EQ(kNumberOfInternalFields, templ->InternalFieldCount());
38 v8::Handle<v8::Object> wrapper = templ->NewInstance(); 42 v8::Handle<v8::Object> wrapper = templ->NewInstance();
39 wrapper->SetAlignedPointerInInternalField(kWrapperInfoIndex, info); 43 wrapper->SetAlignedPointerInInternalField(kWrapperInfoIndex, info);
40 wrapper->SetAlignedPointerInInternalField(kEncodedValueIndex, this); 44 wrapper->SetAlignedPointerInInternalField(kEncodedValueIndex, this);
41 wrapper_.Reset(isolate, wrapper); 45 wrapper_.Reset(isolate, wrapper);
42 wrapper_.SetWeak(this, WeakCallback); 46 wrapper_.SetWeak(this, WeakCallback);
43 return wrapper; 47 return wrapper;
44 } 48 }
45 49
46 } // namespace gin 50 } // namespace gin
OLDNEW
« gin/wrappable.h ('K') | « gin/wrappable.h ('k') | gin/wrappable_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698