Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: gin/wrappable.cc

Issue 105743007: Gin: Make it easier to implement Wrappable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « gin/wrappable.h ('k') | gin/wrappable_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gin/wrappable.h" 5 #include "gin/wrappable.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "gin/per_isolate_data.h" 8 #include "gin/per_isolate_data.h"
9 9
10 namespace gin { 10 namespace gin {
11 11
12 Wrappable::Wrappable() { 12 WrappableBase::WrappableBase() {
13 } 13 }
14 14
15 Wrappable::~Wrappable() { 15 WrappableBase::~WrappableBase() {
16 wrapper_.Reset(); 16 wrapper_.Reset();
17 } 17 }
18 18
19 v8::Handle<v8::Object> Wrappable::GetWrapper(v8::Isolate* isolate) { 19 v8::Handle<v8::Object> WrappableBase::GetWrapperImpl(
20 if (wrapper_.IsEmpty()) 20 v8::Isolate* isolate, WrapperInfo* wrapper_info) {
21 CreateWrapper(isolate); 21 if (wrapper_.IsEmpty())
22 return v8::Local<v8::Object>::New(isolate, wrapper_); 22 CreateWrapper(isolate, wrapper_info);
23 return v8::Local<v8::Object>::New(isolate, wrapper_);
23 } 24 }
24 25
25 void Wrappable::WeakCallback( 26 void WrappableBase::WeakCallback(
26 const v8::WeakCallbackData<v8::Object, Wrappable>& data) { 27 const v8::WeakCallbackData<v8::Object, WrappableBase>& data) {
27 Wrappable* wrappable = data.GetParameter(); 28 WrappableBase* wrappable = data.GetParameter();
28 wrappable->wrapper_.Reset(); 29 wrappable->wrapper_.Reset();
29 delete wrappable; 30 delete wrappable;
30 } 31 }
31 32
32 v8::Handle<v8::Object> Wrappable::CreateWrapper(v8::Isolate* isolate) { 33 v8::Handle<v8::Object> WrappableBase::CreateWrapper(v8::Isolate* isolate,
33 WrapperInfo* info = GetWrapperInfo(); 34 WrapperInfo* info) {
34 PerIsolateData* data = PerIsolateData::From(isolate); 35 PerIsolateData* data = PerIsolateData::From(isolate);
35 v8::Local<v8::ObjectTemplate> templ = data->GetObjectTemplate(info); 36 v8::Local<v8::ObjectTemplate> templ = data->GetObjectTemplate(info);
36 CHECK(!templ.IsEmpty()); // Don't forget to register an object template. 37 CHECK(!templ.IsEmpty()); // Don't forget to register an object template.
37 CHECK_EQ(kNumberOfInternalFields, templ->InternalFieldCount()); 38 CHECK_EQ(kNumberOfInternalFields, templ->InternalFieldCount());
38 v8::Handle<v8::Object> wrapper = templ->NewInstance(); 39 v8::Handle<v8::Object> wrapper = templ->NewInstance();
39 wrapper->SetAlignedPointerInInternalField(kWrapperInfoIndex, info); 40 wrapper->SetAlignedPointerInInternalField(kWrapperInfoIndex, info);
40 wrapper->SetAlignedPointerInInternalField(kEncodedValueIndex, this); 41 wrapper->SetAlignedPointerInInternalField(kEncodedValueIndex, this);
41 wrapper_.Reset(isolate, wrapper); 42 wrapper_.Reset(isolate, wrapper);
42 wrapper_.SetWeak(this, WeakCallback); 43 wrapper_.SetWeak(this, WeakCallback);
43 return wrapper; 44 return wrapper;
44 } 45 }
45 46
47 namespace internal {
48
49 void* FromV8Impl(v8::Isolate* isolate, v8::Handle<v8::Value> val,
50 WrapperInfo* wrapper_info) {
51 if (!val->IsObject())
52 return NULL;
53 v8::Handle<v8::Object> obj = v8::Handle<v8::Object>::Cast(val);
54 WrapperInfo* info = WrapperInfo::From(obj);
55
56 // If this fails, the object is not managed by Gin. It is either a normal JS
57 // object that's not wrapping any external C++ object, or it is wrapping some
58 // C++ object, but that object isn't managed by Gin (maybe Blink).
59 if (!info)
60 return NULL;
61
62 // If this fails, the object is managed by Gin, but it's not wrapping an
63 // instance of the C++ class associated with wrapper_info.
64 if (info != wrapper_info)
65 return NULL;
66
67 return obj->GetAlignedPointerFromInternalField(kEncodedValueIndex);
68 }
69
70 } // namespace internal
71
46 } // namespace gin 72 } // namespace gin
OLDNEW
« no previous file with comments | « gin/wrappable.h ('k') | gin/wrappable_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698