include/core/SkPicture.h - Issue 1057413005: Remove filename from SkFontDescriptor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkPicture.h

Issue 1057413005: Remove filename from SkFontDescriptor. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add missing space. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkPicture.h

diff --git a/include/core/SkPicture.h b/include/core/SkPicture.h

index f514828e56148e00c9f6dd5ad5f768ee2e4df773..f0a0091571ab30278e2b8ed7854a74aa41769693 100644

--- a/include/core/SkPicture.h

+++ b/include/core/SkPicture.h

@@ -253,6 +253,8 @@ private:

static const uint32_t MIN_PICTURE_VERSION = 35; // Produced by Chrome M39.

static const uint32_t CURRENT_PICTURE_VERSION = 41;

+ static_assert(MIN_PICTURE_VERSION <= 41, "Remove kFontFileName and related code.");

mtklein 2015/04/17 17:46:22 Might add "from SkFontDescriptor.cpp"?

bungeman-skia 2015/04/17 17:50:27 What, and use a whole new line? Done.

void createHeader(SkPictInfo* info) const;

static bool IsValidPictInfo(const SkPictInfo& info);

« no previous file with comments | « no previous file | src/core/SkFontDescriptor.h » ('j') | no next file with comments »