Remove filename from SkFontDescriptor.

Remove filename from SkFontDescriptor.

No one actually uses it, so remove it. Keep the string id for backward
compatibility.

TBR=reed@google.com
This doesn't change any public API.

Committed: https://skia.googlesource.com/skia/+/9d911d5a9323bda1e4a77c46a0c28708dcc2ad38

[bungeman-skia, 2015-04-17 16:57:21]

bungeman@google.com changed reviewers:
+ mtklein@google.com

[bungeman-skia, 2015-04-17 16:57:21]

reed indicated that he'd like this to get done at some point, and I'd like it
done now too, so remove all the dead things!!!

[mtklein, 2015-04-17 17:00:46]

https://codereview.chromium.org/1057413005/diff/1/src/core/SkFontDescriptor.cpp
File src/core/SkFontDescriptor.cpp (right):

https://codereview.chromium.org/1057413005/diff/1/src/core/SkFontDescriptor.c...
src/core/SkFontDescriptor.cpp:79: break;
Why do we keep this around?  For serialized pictures?  If so, better bump the
picture version and mark this code up like the rest with things that say "you
can remove this once the minimum picture version passes NN".

[bungeman-skia, 2015-04-17 17:44:51]

Added all the things for future removal.

https://codereview.chromium.org/1057413005/diff/1/src/core/SkFontDescriptor.cpp
File src/core/SkFontDescriptor.cpp (right):

https://codereview.chromium.org/1057413005/diff/1/src/core/SkFontDescriptor.c...
src/core/SkFontDescriptor.cpp:79: break;
On 2015/04/17 17:00:46, mtklein wrote:
> Why do we keep this around?  For serialized pictures?  If so, better bump the
> picture version and mark this code up like the rest with things that say "you
> can remove this once the minimum picture version passes NN".

Added assert to SkPicture.h and comments here.

[mtklein, 2015-04-17 17:46:22]

lgtm

https://codereview.chromium.org/1057413005/diff/60001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/1057413005/diff/60001/include/core/SkPicture....
include/core/SkPicture.h:256: static_assert(MIN_PICTURE_VERSION <= 41, "Remove
kFontFileName and related code.");
Might add "from SkFontDescriptor.cpp"?

[bungeman-skia, 2015-04-17 17:50:27]

https://codereview.chromium.org/1057413005/diff/60001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/1057413005/diff/60001/include/core/SkPicture....
include/core/SkPicture.h:256: static_assert(MIN_PICTURE_VERSION <= 41, "Remove
kFontFileName and related code.");
On 2015/04/17 17:46:22, mtklein wrote:
> Might add "from SkFontDescriptor.cpp"?

What, and use a whole new line? Done.

[bungeman-skia, 2015-04-17 17:50:49]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2015-04-17 17:50:49]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1057413005/#ps70001
(title: "Add file name to assert.")

[commit-bot: I haz the power, 2015-04-17 17:51:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1057413005/70001

[commit-bot: I haz the power, 2015-04-17 17:51:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-17 17:51:12]

Presubmit check for 1057413005-70001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

Presubmit checks took 1.4s to calculate.

[bungeman-skia, 2015-04-17 17:52:47]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-04-17 17:53:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1057413005/70001

[commit-bot: I haz the power, 2015-04-17 17:53:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-17 17:53:09]

Presubmit check for 1057413005-70001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

[bungeman-skia, 2015-04-17 17:53:55]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-04-17 17:54:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1057413005/70001

[commit-bot: I haz the power, 2015-04-17 18:00:11]

Committed patchset #5 (id:70001) as
https://skia.googlesource.com/skia/+/9d911d5a9323bda1e4a77c46a0c28708dcc2ad38