pkg/analysis_server/lib/src/services/completion/keyword_computer.dart - Issue 1057403003: fix keyword completion in class body

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/keyword_computer.dart

Issue 1057403003: fix keyword completion in class body (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address comment Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/services/completion/keyword_computer.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/keyword_computer.dart b/pkg/analysis_server/lib/src/services/completion/keyword_computer.dart

index f688f2fa0100ec573e5bcbd7e328ea2e8abf86e3..24415bd5a58187abe407929d9f75958e8c0370e3 100644

--- a/pkg/analysis_server/lib/src/services/completion/keyword_computer.dart

+++ b/pkg/analysis_server/lib/src/services/completion/keyword_computer.dart

@@ -70,7 +70,7 @@ class _KeywordVisitor extends GeneralizingAstVisitor {

if (entity == node.name) {

return;

}

- if (entity == node.rightBracket) {

+ if (entity == node.rightBracket || entity is ClassMember) {

_addSuggestions([

Keyword.CONST,

Keyword.DYNAMIC,

« no previous file with comments | « no previous file | pkg/analysis_server/test/completion_test.dart » ('j') | no next file with comments »