Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 1057393004: Add unit test for the back button in the new GAIA. (Closed)

Created:
5 years, 8 months ago by Ivan Podogov
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unit test for the back button in the new GAIA. BUG=475566 Committed: https://crrev.com/069e1f8c090a54cc71d5dc0b4ec4dfb5012c647e Cr-Commit-Position: refs/heads/master@{#325206}

Patch Set 1 #

Patch Set 2 : Remove unnecessary line. #

Patch Set 3 : Check current page location. #

Total comments: 1

Patch Set 4 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M chrome/browser/chromeos/login/webview_login_browsertest.cc View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M google_apis/test/embedded_setup_chromeos.html View 1 2 3 3 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Ivan Podogov
PTAL
5 years, 8 months ago (2015-04-14 15:13:09 UTC) #2
Roger Tawa OOO till Jul 10th
google_apis lgtm
5 years, 8 months ago (2015-04-14 18:55:16 UTC) #3
Nikita (slow)
lgtm https://codereview.chromium.org/1057393004/diff/40001/google_apis/test/embedded_setup_chromeos.html File google_apis/test/embedded_setup_chromeos.html (right): https://codereview.chromium.org/1057393004/diff/40001/google_apis/test/embedded_setup_chromeos.html#newcode57 google_apis/test/embedded_setup_chromeos.html:57: history.replaceState({}, "", window.location.pathname + "#identifier"); nit: Use ' ...
5 years, 8 months ago (2015-04-14 20:06:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057393004/60001
5 years, 8 months ago (2015-04-15 07:23:25 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-15 07:53:44 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 07:54:41 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/069e1f8c090a54cc71d5dc0b4ec4dfb5012c647e
Cr-Commit-Position: refs/heads/master@{#325206}

Powered by Google App Engine
This is Rietveld 408576698