Issue 1057333003: Rename the parameter to MojoMain() from "service_provider_handle" to "application_request "

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1057333003: Rename the parameter to MojoMain() from "service_provider_handle" to "application_request " (Closed)

Created:
5 years, 8 months ago by rudominer

Modified:
5 years, 8 months ago

Reviewers:
viettrungluu

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Rename the parameter to MojoMain() from "service_provider_handle" to "application_request " R=viettrungluu@chromium.org, viettrungluu BUG=468496 Committed: https://chromium.googlesource.com/external/mojo/+/1561910f1212ef39403642c068bf67df129fa236

Patch Set 1 #

Patch Set 2 : Fix spelling error. #

Patch Set 3 : rebased #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	mojo/public/c/system/main.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	shell/native_application_support.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rudominer

5 years, 8 months ago (2015-04-10 17:44:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
1561910f1212ef39403642c068bf67df129fa236 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages