Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 105733008: Let Node.nodeName never return null (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, arv+blink, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Let Node.nodeName never return null http://dom.spec.whatwg.org/#dom-node-nodename Since I could not find any case where it would currently return null, no observable diference is expected and no tests were added. Also remove an outdated comment. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/dom/Node.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
7 years ago (2013-12-05 14:21:06 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years ago (2013-12-05 14:22:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/105733008/1
7 years ago (2013-12-05 14:26:32 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-05 15:39:04 UTC) #4
Message was sent while issue was closed.
Change committed as 163269

Powered by Google App Engine
This is Rietveld 408576698