Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 1057283002: Permissions: use newly supported required attribute on Dictionary properties. (Closed)

Created:
5 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 8 months ago
Reviewers:
whywhat
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Permissions: use newly supported required attribute on Dictionary properties. This is removing the custom checks and rely on the bindings instead. Also adding a couple of tests regarding bindings. This CL doesn't change any behaviour. BUG=437770 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M LayoutTests/http/tests/permissions/resources/test-query.js View 1 chunk +17 lines, -0 lines 0 comments Download
M Source/modules/permissions/PermissionDescriptor.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/permissions/Permissions.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mlamouri (slow - plz ping)
5 years, 8 months ago (2015-04-03 13:02:22 UTC) #2
whywhat
Shouldn't you have a then() with assert_notreached() in your second test case (with empty name)? ...
5 years, 8 months ago (2015-04-03 13:09:21 UTC) #3
mlamouri (slow - plz ping)
On 2015/04/03 at 13:09:21, avayvod wrote: > Shouldn't you have a then() with assert_notreached() in ...
5 years, 8 months ago (2015-04-03 13:11:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057283002/1
5 years, 8 months ago (2015-04-03 13:16:04 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 14:25:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193120

Powered by Google App Engine
This is Rietveld 408576698