Add the scheme chrome-distiller:// and hook up data source.

components/dom_distiller/webui/dom_distiller_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/dom_distiller/webui/dom_distiller_handler.h"
 
 #include "base/bind.h"
 #include "base/values.h"
 #include "components/dom_distiller/core/dom_distiller_service.h"
 #include "components/dom_distiller/core/proto/distilled_page.pb.h"
+#include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
 #include "url/gurl.h"
 
 namespace dom_distiller {
 
 DomDistillerHandler::DomDistillerHandler(DomDistillerService* service,
                                          const std::string& scheme)
     : weak_ptr_factory_(this),
       service_(service) {
   article_scheme_ = scheme;
@@ skipping 23 matching lines @@
   if (gurl.is_valid())
     service_->AddToList(gurl);
   else
     web_ui()->CallJavascriptFunction("domDistiller.onArticleAddFailed");
 }
 
 void DomDistillerHandler::HandleSelectArticle(const ListValue* args) {
   std::string entry_id;
   args->GetString(0, &entry_id);
 
-  // TODO(nyquist): Do something here.
+  GURL url(article_scheme_ + std::string("://") + entry_id);
+  DCHECK(url.is_valid());
+  web_ui()->GetWebContents()->GetController().LoadURL(url,

[Tom Sepez, 2013/12/05 19:25:52]

@creis - would this load into the same renderer as other open webui?

[Charlie Reis, 2013/12/06 22:09:32]

That depends on whether chrome-distiller:// URLs have WebUI bindings.  The check
is in RenderProcessHostImpl::IsSuitableHost, which passes the URL to
WebUIControllerFactoryRegistry::GetInstance()->UseWebUIBindingsForURL.

Why do we need a new scheme for this, though?  Adding new schemes tends to be
risky work, and we avoid it whenever possible.  For example, we have to know
whether it's legal to navigate from normal pages to this scheme, or from this
scheme to chrome://.  (There's a warning in
content/public/common/url_constants.cc.)

[nyquist, 2013/12/06 22:25:44]

chrome-distiller:// does use a WebUI to render things. A new scheme was proposed
to ensure that chrome:// does not get compromised since the content that will be
rendered is inherently not trusted.

Also, this will probably in the end be rendered in an iframe, and not as a top
level navigation. However, this CL doesn't support that yet.

[Charlie Reis, 2013/12/06 22:33:03]

I don't think this won't guarantee that.  If the user has many tabs open, it
looks like any WebUI pages could end up sharing a process.

I'm concerned about a WebUI-enabled process that contains untrusted content.  I
don't think we've had to support that in the past.
What would the top-level URL be?  The process is currently decided by the
top-level URL, since we don't have out-of-process iframes working yet.  We
wouldn't be able to grant WebUI bindings to just an iframe and not the rest of
the process.

[nyquist, 2014/01/08 02:00:41]

Changed to implement as a data source instead.
chrome-distiller://123-abc for entries. Not decided for on-the-fly URLs yet.

+      content::Referrer(), content::PAGE_TRANSITION_GENERATED,
+      std::string());
 }
 
 void DomDistillerHandler::HandleRequestEntries(const ListValue* args) {
   base::ListValue entries;
   const std::vector<ArticleEntry>& entries_specifics = service_->GetEntries();
   for (std::vector<ArticleEntry>::const_iterator it = entries_specifics.begin();
        it != entries_specifics.end();
        ++it) {
     const ArticleEntry& article = *it;
     DCHECK(IsEntryValid(article));
     scoped_ptr<base::DictionaryValue> entry(new base::DictionaryValue());
     entry->SetString("entry_id", article.entry_id());
     std::string title = (!article.has_title() || article.title().empty()) ?
         article.entry_id() : article.title();
     entry->SetString("title", title);
     entries.Append(entry.release());
   }
   web_ui()->CallJavascriptFunction("domDistiller.onReceivedEntries", entries);
 }
 
 }  // namespace dom_distiller