Use SingleThreadTaskRunner instead of MessageLoopProxy in remoting/host.

remoting/host/chromoting_host_context.h

Index: remoting/host/chromoting_host_context.h
diff --git a/remoting/host/chromoting_host_context.h b/remoting/host/chromoting_host_context.h
index 7476986ad605ec9efba49d996a015103cf4e5086..5ac070531d0c2e9d4b8521d67f2ac522c8d50784 100644
--- a/remoting/host/chromoting_host_context.h
+++ b/remoting/host/chromoting_host_context.h
@@ -8,10 +8,15 @@
 #include <string>
 
 #include "base/gtest_prod_util.h"
+#include "base/memory/ref_counted.h"
 #include "base/threading/platform_thread.h"
 #include "base/threading/thread.h"
 #include "remoting/jingle_glue/jingle_thread.h"
 
+namespace base {
+class SingleThreadTaskRunner;
+}  // namespace base
+
 namespace net {
 class URLRequestContextGetter;
 }  // namespace net
@@ -23,7 +28,8 @@ namespace remoting {
 class ChromotingHostContext {
  public:
   // Create a context.
-  ChromotingHostContext(base::MessageLoopProxy* ui_message_loop);
+  ChromotingHostContext(
+      scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner);
   virtual ~ChromotingHostContext();
 
   // TODO(ajwong): Move the Start method out of this class. Then
@@ -35,13 +41,20 @@ class ChromotingHostContext {
 
   virtual JingleThread* jingle_thread();
 
-  virtual MessageLoop* main_message_loop();
-  virtual MessageLoop* encode_message_loop();
-  virtual base::MessageLoopProxy* network_message_loop();
-  virtual MessageLoop* desktop_message_loop();
-  virtual base::MessageLoopProxy* ui_message_loop();
-  virtual base::MessageLoopProxy* io_message_loop();
-  virtual base::MessageLoopProxy* file_message_loop();
+  virtual base::SingleThreadTaskRunner* main_task_runner();
+
+  // The task runner for the thread used to encode video streams.
+  virtual base::SingleThreadTaskRunner* encode_task_runner();
+
+  // Network thread is the thread use for most networking IO. It runs
+  // libjingle's message loop, so libjingle code should be used only
+  // on this thread.
+  virtual base::SingleThreadTaskRunner* network_task_runner();
+
+  virtual base::SingleThreadTaskRunner* desktop_task_runner();
+  virtual base::SingleThreadTaskRunner* ui_task_runner();
+  virtual base::SingleThreadTaskRunner* io_task_runner();
+  virtual base::SingleThreadTaskRunner* file_task_runner();

[Wez, 2012/06/19 03:47:08]

You've added comments to clarify some of the TaskRunners but not others? e.g.
What is the difference between the IO and file TaskRunners? What's the main one
used for?

[Sergey Ulanov, 2012/06/19 18:16:09]

Oh, sorry. I actually had these comments added already, but just forgot to
upload new patchset. Also renamed main_task_runner() to capture_task_runner().
Please take another look.

   const scoped_refptr<net::URLRequestContextGetter>&
       url_request_context_getter();
 
@@ -68,7 +81,7 @@ class ChromotingHostContext {
   // Thread for blocking IO operations.
   base::Thread file_thread_;
 
-  scoped_refptr<base::MessageLoopProxy> ui_message_loop_;
+  scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
 
   scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;