gpu/command_buffer/client/gles2_implementation.cc - Issue 1057183002: Fix a few lints found while working on crrev.com/1051503003.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/client/gles2_implementation.cc

Issue 1057183002: Fix a few lints found while working on crrev.com/1051503003. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More lints removed. "git cl format" reverted. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/gpu_memory_buffer_factory_shared_memory.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/client/gles2_implementation.cc

diff --git a/gpu/command_buffer/client/gles2_implementation.cc b/gpu/command_buffer/client/gles2_implementation.cc

index 139dc6593545ae8d1b0744b14f176da0d9847978..78690af15964f81d3d324bec04b635838eeae0ee 100644

--- a/gpu/command_buffer/client/gles2_implementation.cc

+++ b/gpu/command_buffer/client/gles2_implementation.cc

@@ -2421,7 +2421,7 @@ bool GLES2Implementation::GetActiveUniformBlockNameHelper(

} else if (length || name) {

std::vector<int8> str;

GetBucketContents(kResultBucketId, &str);

- DCHECK(str.size() > 0);

+ DCHECK_GT(str.size(), 0u);

GLsizei max_size =

std::min(bufsize, static_cast<GLsizei>(str.size())) - 1;

if (length) {

« no previous file with comments | « content/common/gpu/gpu_memory_buffer_factory_shared_memory.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »