content_browsertests.isolate: ppapi_tests requires enable_plugins=1.

build/isolate.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This file is meant to be included into a target to provide a rule
 # to "build" .isolate files into a .isolated file.
 #
 # To use this, create a gyp target with the following form:
 # 'conditions': [
 #   ['test_isolation_mode != "noop"', {
@@ skipping 62 matching lines @@
         # Extra variables are replaced on the 'command' entry and on paths in
         # the .isolate file but are not considered relative paths.
         '--extra-variable', 'version_full=<(version_full)',
 
         '--config-variable', 'CONFIGURATION_NAME=<(CONFIGURATION_NAME)',
         '--config-variable', 'OS=<(OS)',
         '--config-variable', 'asan=<(asan)',
         '--config-variable', 'chromeos=<(chromeos)',
         '--config-variable', 'component=<(component)',
         '--config-variable', 'disable_nacl=<(disable_nacl)',
+        '--config-variable', 'enable_plugins=<(enable_plugins)',

[M-A Ruel, 2015/04/03 00:45:26]

http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...

I don't see enable_plugins here.
Is nacl enabled at all? Because I'd prefer to key on disable_nacl==0.

[gunsch, 2015/04/03 00:48:38]

enable_plugins is set to 0 when chromecast==1 (see embedded==1 in
build/common.gypi).


I chose enable_plugins because that's how it's linked into content_tests, so
that's how it seems like it should be guarded in the .isolate file:

https://code.google.com/p/chromium/codesearch#chromium/src/content/content_te...

Should that condition also be disable_nacl?

[M-A Ruel, 2015/04/03 00:56:08]

My question is:
is disable_nacl==0 set when chromecast==1. Because there's way more people
desiring proper support for disable_nacl==0. I agree that enable_plugins is way
more than just nacl but from the perspective of this specific file, it doesn't
matter.

[gunsch, 2015/04/03 01:38:03]

To make sure we're on the same page: do most builds have both "disable_nacl=0
and enable_plugins=1"? I'm not sure which value of disable_nacl you're asking
ppapi_tests to be included in the .isolate for.

We generally set disable_nacl=1 when chromecast=1, though I noticed we only do
so in our internal build scripts (which tack on a lot more GYP_DEFINES). I've
added disable_nacl=1 explicitly to build/common.gypi when chromecast=1, and then
guarded it here in content_browsertests.isolate.

         '--config-variable', 'fastbuild=<(fastbuild)',
         '--config-variable', 'icu_use_data_file_flag=<(icu_use_data_file_flag)',
         # TODO(kbr): move this to chrome_tests.gypi:gles2_conform_tests_run
         # once support for user-defined config variables is added.
         '--config-variable',
           'internal_gles2_conform_tests=<(internal_gles2_conform_tests)',
         '--config-variable', 'libpeer_target_type=<(libpeer_target_type)',
         '--config-variable', 'lsan=<(lsan)',
         '--config-variable', 'msan=<(msan)',
         '--config-variable', 'target_arch=<(target_arch)',
@@ skipping 25 matching lines @@
           ],
         }, {
           'outputs': [
             '<(PRODUCT_DIR)/<(RULE_INPUT_ROOT).isolated',
           ],
         }],
       ],
     },
   ],
 }