Issue 105713005: Mac-specific implementation of the GlobalShortcutListener class that

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 105713005: Mac-specific implementation of the GlobalShortcutListener class that (Closed)

Created:
7 years ago by Finnur

Modified:
7 years ago

Reviewers:
Finnur

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Boris Smus

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Previously reviewed here: https://codereview.chromium.org/60353008/ Mac-specific implementation of the GlobalShortcutListener class that listens for global shortcuts. Handles basic keyboard intercepting and forwards its output to the base class for processing. Adds two things: 1. Intercepts media keys. Uses an event tap for intercepting media keys (PlayPause, NextTrack, PreviousTrack). 2. Binds keyboard shortcuts (hot keys). Carbon RegisterEventHotKey API for binding to non-media key global hot keys (eg. Command-Shift-1). Mac tests added but disabled while we figure out flakiness it causes in another test. BUG=302437 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241864

Patch Set 1 #

Patch Set 2 : Disable test for now #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+515 lines, -82 lines)			Patch
M	chrome/browser/extensions/api/commands/command_service.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_commands_global_registry_apitest.cc	View	1	6 chunks	+55 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/global_shortcut_listener_mac.h	View		2 chunks	+68 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/global_shortcut_listener_mac.cc	View		1 chunk	+0 lines, -75 lines	0 comments	Download
A	chrome/browser/extensions/global_shortcut_listener_mac.mm	View		1 chunk	+384 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #2 manually as r241864.

Expand Messages | Collapse Messages