Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1057103004: Files.app: Minor updates on font size, spacing, and color. (Closed)

Created:
5 years, 8 months ago by fukino
Modified:
5 years, 8 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Minor updates on font size, spacing, and color. - Breadcrumb's font is 14px bold. - Horizontal margin for dialog buttons is slightly expanded. - Cancel button's color is dark gray. BUG=470621 TEST=manually Committed: https://crrev.com/4feb24fc5e5b7033574c61084edce9a9b71d7f66 Cr-Commit-Position: refs/heads/master@{#323670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M ui/file_manager/file_manager/foreground/css/common.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_manager.css View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
fukino
PTAL. Thanks!
5 years, 8 months ago (2015-04-03 03:07:10 UTC) #2
yawano
lgtm with nit. nit: In CL description 14pt should be 14px?
5 years, 8 months ago (2015-04-03 03:50:18 UTC) #3
fukino
On 2015/04/03 03:50:18, yawano wrote: > lgtm with nit. > nit: In CL description 14pt ...
5 years, 8 months ago (2015-04-03 04:12:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057103004/1
5 years, 8 months ago (2015-04-03 04:44:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-03 07:51:17 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:34:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4feb24fc5e5b7033574c61084edce9a9b71d7f66
Cr-Commit-Position: refs/heads/master@{#323670}

Powered by Google App Engine
This is Rietveld 408576698