Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 1057083006: Revert of Adding checks in sandbox code to get some data on AppContainer based CreateProcess failures. (Closed)

Created:
5 years, 8 months ago by Shrikant Kelkar
Modified:
5 years, 8 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding checks in sandbox code to get some data on AppContainer based CreateProcess failures. (patchset #2 id:20001 of https://codereview.chromium.org/1093443002/) Reason for revert: Collected dumps, reverting. Original issue's description: > Adding checks in sandbox code to get some data on AppContainer based CreateProcess failures. > Due to limited debugging options, given it doesn't repro locally, adding some checks in sandbox code to gather more data. > > BUG=467920 > R=jschuh@chromium.org,cpu@chromium.org > > Committed: https://crrev.com/cb0da85dcf65824f96233ed77fd04d99b4c031cb > Cr-Commit-Position: refs/heads/master@{#325663} TBR=cpu@chromium.org,jschuh@chromium.org,wfh@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467920 Committed: https://crrev.com/790be872f460ead8d7ca21c490077dab0a6d21ac Cr-Commit-Position: refs/heads/master@{#325793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
M sandbox/win/src/target_process.cc View 7 chunks +0 lines, -34 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Shrikant Kelkar
5 years, 8 months ago (2015-04-18 23:47:46 UTC) #1
Created Revert of Adding checks in sandbox code to get some data on AppContainer
based CreateProcess failures.

Powered by Google App Engine
This is Rietveld 408576698