Fix menu list and list box screen reader accessibility.

content/browser/accessibility/browser_accessibility_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <execinfo.h>
 
 #import "content/browser/accessibility/browser_accessibility_cocoa.h"
 
 #include <map>
 
@@ skipping 740 matching lines @@
         [ret addObject:rowElement->ToBrowserAccessibilityCocoa()];
     }
   }
 
   return ret;
 }
 
 - (NSArray*)selectedChildren {
   NSMutableArray* ret = [[[NSMutableArray alloc] init] autorelease];
 
-  BrowserAccessibilityManager* manager = browserAccessibility_->manager();
-  BrowserAccessibility* focusedChild =
-      manager->GetFocus(browserAccessibility_);
-  if (focusedChild && focusedChild != browserAccessibility_) {
+  // If it's not multiselectable, try to skip iterating over the
+  // children.
+  if (!GetState(browserAccessibility_, ui::AX_STATE_MULTISELECTABLE)) {
     // First try the focused child.
-    [ret addObject:focusedChild->ToBrowserAccessibilityCocoa()];
-  } else {
+    BrowserAccessibilityManager* manager = browserAccessibility_->manager();
+    BrowserAccessibility* focusedChild =
+        manager->GetFocus(browserAccessibility_);
+    if (focusedChild && focusedChild != browserAccessibility_) {
+      [ret addObject:focusedChild->ToBrowserAccessibilityCocoa()];
+      return ret;
+    }
+
     // Next try the active descendant.
     int activeDescendantId;
     if (browserAccessibility_->GetIntAttribute(
             ui::AX_ATTR_ACTIVEDESCENDANT_ID, &activeDescendantId)) {
       BrowserAccessibility* activeDescendant =
           manager->GetFromID(activeDescendantId);
-      if (activeDescendant)
+      if (activeDescendant) {
         [ret addObject:activeDescendant->ToBrowserAccessibilityCocoa()];
-    } else {
-      // Otherwise return any children with the "selected" state, which
-      // may come from aria-selected.
-      uint32 childCount = browserAccessibility_->PlatformChildCount();
-      for (uint32 index = 0; index < childCount; ++index) {
-        BrowserAccessibility* child =
-            browserAccessibility_->PlatformGetChild(index);
-        if (child->HasState(ui::AX_STATE_SELECTED))
-          [ret addObject:child->ToBrowserAccessibilityCocoa()];
+        return ret;
       }
     }
   }
 
+  // If it's multiselectable or if the previous attempts failed,
+  // return any children with the "selected" state, which may
+  // come from aria-selected.
+  uint32 childCount = browserAccessibility_->PlatformChildCount();
+  for (uint32 index = 0; index < childCount; ++index) {
+    BrowserAccessibility* child =
+      browserAccessibility_->PlatformGetChild(index);
+    if (child->HasState(ui::AX_STATE_SELECTED))
+      [ret addObject:child->ToBrowserAccessibilityCocoa()];
+  }
+
   return ret;
 }
 
 // Returns the size of this object.
 - (NSValue*)size {
   gfx::Rect bounds = browserAccessibility_->GetLocalBoundsRect();
   return  [NSValue valueWithSize:NSMakeSize(bounds.width(), bounds.height())];
 }
 
 - (NSString*)sortDirection {
@@ skipping 825 matching lines @@
   if (!browserAccessibility_)
     return [super hash];
   return browserAccessibility_->GetId();
 }
 
 - (BOOL)accessibilityShouldUseUniqueId {
   return YES;
 }
 
 @end